Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test load image issue #8297

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

yiheng-wang-nv
Copy link
Contributor

@yiheng-wang-nv yiheng-wang-nv commented Jan 14, 2025

Fixes #8274 .

Description

The new test has already tested with the same 24.08 + A100 env.

I did some tests but cannot reproduce the original test case error (there are NaN values or significant small/large data). Since only 24.08 base image has the issue (24.10 does not have), I decided to use a different test case for 24.08 and prepared this PR

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Yiheng Wang <[email protected]>
@KumoLiu
Copy link
Contributor

KumoLiu commented Jan 14, 2025

/build

@KumoLiu
Copy link
Contributor

KumoLiu commented Jan 14, 2025

Hi @yiheng-wang-nv, please add some description in the PR to know why you change it to randint. Thanks.

Signed-off-by: Yiheng Wang <[email protected]>
@KumoLiu
Copy link
Contributor

KumoLiu commented Jan 14, 2025

/build

@KumoLiu KumoLiu merged commit eaa901c into Project-MONAI:dev Jan 14, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AssertionError in test_load_image
2 participants